Skip to content

Revert "CI: Use DeepSeek-R1-0528-mtp-mxfp4 models for deepseek fp4 tests" #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gyohuangxin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revert "CI: Use DeepSeek-R1-0528-mtp-mxfp4 models for deepseek fp4 tests" #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/atom-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@ jobs:
env_vars: ""
runner: atom-mi355-8gpu.predownload
- model_name: "DeepSeek-R1-0528-FP4"
model_path: "amd/DeepSeek-R1-0528-mtp-mxfp4"
model_path: "amd/DeepSeek-R1-0528-MXFP4"
extraArgs: "--kv_cache_dtype fp8 -tp 8"
env_vars: ""
runner: atom-mi355-8gpu.predownload
- model_name: "DeepSeek-R1-0528-FP4 MTP"
model_path: "amd/DeepSeek-R1-0528-mtp-mxfp4"
model_path: "amd/DeepSeek-R1-0528-MXFP4"
extraArgs: "--kv_cache_dtype fp8 -tp 8 --method mtp"
Comment on lines 49 to 56
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model_name labels these entries as "FP4", but the reverted model_path points at an "MXFP4" model repo. This mismatch makes CI matrix results harder to interpret/debug; consider aligning model_name with the actual repo name (or adding MXFP4 to the label) so logs/artifacts clearly indicate which model variant was tested.

Copilot uses AI. Check for mistakes.
env_vars: ""
runner: atom-mi355-8gpu.predownload
Expand Down Expand Up @@ -183,7 +183,7 @@ jobs:
run: |
if [ -d "/models" ]; then
echo "/models directory found, downloading model to /models/${{ matrix.model_path }}"
if ! docker exec -e HF_TOKEN=${{ secrets.AMD_HF_TOKEN }} atom_test bash -lc "hf download ${{ matrix.model_path }} --local-dir /models/${{ matrix.model_path }}"; then
if ! docker exec atom_test bash -lc "hf download ${{ matrix.model_path }} --local-dir /models/${{ matrix.model_path }}"; then
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hf download invocation no longer passes HF_TOKEN (previously sourced from a secret) and the job does not set HF_TOKEN anywhere, so downloads will run unauthenticated unless the self-hosted runner environment provides HF_TOKEN. If any of these model repos are gated/private or hit rate limits, this step will fail; consider restoring token injection here or explicitly setting HF_TOKEN at the job/step level from an appropriate secret.

Copilot uses AI. Check for mistakes.
echo "Model download failed for '${{ matrix.model_path }}'. Aborting."
exit 1
fi
Expand Down
Loading