Skip to content

Comments

GLR-HIVE: Hive feedback#2

Open
dvstepanchuk wants to merge 1 commit intoRMDarth:mainfrom
dvstepanchuk:GLR-HIVE
Open

GLR-HIVE: Hive feedback#2
dvstepanchuk wants to merge 1 commit intoRMDarth:mainfrom
dvstepanchuk:GLR-HIVE

Conversation

@dvstepanchuk
Copy link

No description provided.


!echo Running query for Top 5 airlines....;

-- GLC| What about table creation?
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, task didn't have any requirements to store result in any way, so I've just printed the result.
But surely it's pretty easy to add something like "create table result as" before this select

Copy link
Owner

@RMDarth RMDarth Dec 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, actually now it is, I've made this homework before the task was published in git (it was published much later then lection), so I didn't know we need to save result :) I've updated some parts of the home work to correctly match the task


!echo Creating tables...;

-- GLC| The first line in `flights` the is the header, isn't?
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Header is actually filtered because it's not conformant to the scheme (i.e. first column should be int, etc.)
But I agree that if scheme changes in future, header could sneak into table, so I've updated repo - added setting to skip it in both tables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants