Skip to content

kinetis: Add dependency on rtt for LPTMR time base #8722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kYc0o merged 1 commit into from
Mar 2, 2018
Merged

kinetis: Add dependency on rtt for LPTMR time base #8722

kYc0o merged 1 commit into from
Mar 2, 2018

Conversation

@jnohlgard
Copy link
Member

@jnohlgard jnohlgard commented Mar 2, 2018

Contribution description

The current implementation of the periph timer driver on Kinetis uses the RTT as a time reference for the low power timer hardware, so the RTT needs to be included if using the LPTMR device in periph timer.

This PR adds FEATURES_OPTIONAL on kinetis because the RTT is not configured for all boards, so USEMODULE += periph_rtt will fail on boards without RTT e.g. teensy31.

Issues/PRs references

split from #6995

@jnohlgard jnohlgard added Platform: ARM Platform: This PR/issue effects ARM-based platforms Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 2, 2018
@jnohlgard jnohlgard added this to the Release 2018.04 milestone Mar 2, 2018
@jnohlgard jnohlgard requested a review from kYc0o March 2, 2018 06:43
kYc0o
kYc0o approved these changes Mar 2, 2018
View reviewed changes
Copy link
Contributor

@kYc0o kYc0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kYc0o kYc0o merged commit 5451990 into RIOT-OS:master Mar 2, 2018
@jnohlgard jnohlgard deleted the pr/kinetis-rtt-dep branch March 2, 2018 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kYc0o kYc0o kYc0o approved these changes

Assignees

@kYc0o kYc0o

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2018.04

Development

Successfully merging this pull request may close these issues.

2 participants

@jnohlgard @kYc0o