allow to register ICMPv6 echo reply handler #667
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently ICMPv6 echo messages are rather useless as it's impossible to determine whether a reply was received without debug output turned on. This allows to register a function as a ICMPv6 echo reply handler that gets called whenever a echo reply has been received.
Member
|
I would vote for a thread based implementation, as seen in ip and lowpan, since this is the "RIOT way" |
Contributor
Author
|
You are probably right, but I dislike the overhead of having a thread dedicated to ping replies :\ |
Member
|
I was thinking more of a general ICMPv6 thread or to include it into the IPv6 thread and return special flags for ICMP packets. |
Member
|
I agree with @authmillenon. |
Contributor
|
as discussed in dev meeting: a better solution will come after #644 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ICMPv6 echo messages are rather useless as it's impossible to determine whether a reply was received without debug output turned on.
This allows to register a function as an ICMPv6 echo reply handler that gets called whenever an echo reply has been received.