Skip to content

Conversation

@miri64
Copy link
Member

@miri64 miri64 commented Jan 24, 2014

IEEE 802.15.4 has two addressing modes: 16-bit short and the device's
EUI-64. Currently RIOT supports only sending of packets with 16-bit
short addresses via the transceiver interface. This patch allows at
least for the radio chips that support IEEE 802.15.4 to let the
application/upper layer decide which addressing mode to use.

Upper layer implementation will be implemented in follow-up PR to #460 so for now ccn and sixlowpan will not work with this PR

Note: there are some coding convention fixes included in this PR.

@OlegHahm
Copy link
Member

In file included from sc_cc2420.c:5:0:
/home/oleg/git/RIOT/examples/default/../../sys/net/include/ieee802154_frame.h:76:1: warning: `packet' attribute directive ignored [-Wattributes]
sc_cc2420.c: In function `_cc2420_send_handler':
sc_cc2420.c:99:14: error: `ieee802154_packet_t' has no member named `data'
sc_cc2420.c:101:14: error: `ieee802154_packet_t' has no member named `dst'
sc_cc2420.c:104:83: error: `ieee802154_packet_t' has no member named `dst'
sc_cc2420.c:104:99: error: `ieee802154_packet_t' has no member named `data'

when building default for wsn430-v1_4.

And what about all these empty new lines?

@LudwigKnuepfer
Copy link
Member

@LudwigOrtmann add native support

@OlegHahm
Copy link
Member

ACK - merge as soon as follow-up PR to #460 is ready.

@miri64
Copy link
Member Author

miri64 commented Jan 27, 2014

Last push rebases code, uses macros for IEEE address mode tests and adds some error handling

@mehlis
Copy link
Contributor

mehlis commented Jan 27, 2014

I'm happy about the styling changes, but please make them in its own commit :) - because more than 30% of the lines are style changes.

@miri64
Copy link
Member Author

miri64 commented Jan 31, 2014

@mehlis done + rebased

@OlegHahm
Copy link
Member

Just for clarification: this is not yet meant to be merged because #460 follow-up is still missing, right?

@miri64
Copy link
Member Author

miri64 commented Jan 31, 2014

@OlegHahm right.

@mehlis
Copy link
Contributor

mehlis commented Feb 24, 2014

part of #644

@OlegHahm
Copy link
Member

Reviewed (tests will follow as part of #644 testing): ACK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use filter instead

IEEE 802.15.4 has two addressing modes: 16-bit short and the device's
EUI-64. Currently RIOT supports only sending of packets with 16-bit
short addresses via the transceiver interface. This patch allows at
least for the radio chips that support IEEE 802.15.4 to let the
application/upper layer decide which addressing mode to use.

Upper layer implementation will be implemented in follow-up PR to RIOT-OS#460
@miri64 miri64 merged commit fa11d82 into RIOT-OS:master Mar 1, 2014
@miri64 miri64 deleted the variable-radio-addr-len branch March 1, 2014 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants