Skip to content

sys: added a single linked list implementation #2295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
OlegHahm wants to merge 2 commits into from
Closed

sys: added a single linked list implementation #2295

OlegHahm wants to merge 2 commits into from

Conversation

@OlegHahm
Copy link
Member

@OlegHahm OlegHahm commented Jan 13, 2015

Followed @cgundogan's suggestion from #2294 (comment)

@OlegHahm OlegHahm added the Type: new feature The issue requests / The PR implemements a new feature for RIOT label Jan 13, 2015
@cgundogan
Copy link
Member

cgundogan commented Jan 13, 2015

We should investigate whether the ulist and slist implementations differ that much enough to have them both in sys

@OlegHahm
Copy link
Member Author

OlegHahm commented Jan 13, 2015

Yeah, you're probably right. The only added functionality by slist currently seems to be the simple_list_add_head(), basically calling calloc(). I'm trying to get rid of it.

@LudwigKnuepfer
Copy link
Member

LudwigKnuepfer commented Jan 14, 2015

I'm trying to get rid of it.

Which "it"? The calloc here or the dependency on slist in #2294 ?

@OlegHahm
Copy link
Member Author

OlegHahm commented Jan 14, 2015

I meant to get rid of both - but after some thinking I will keep OLSR depending on calloc/free and leave this task for a later point of time.

@OlegHahm OlegHahm added Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet labels Jan 14, 2015
@OlegHahm OlegHahm force-pushed the master branch 3 times, most recently from 9f184dd to 45554bf Compare March 31, 2015 13:01
@miri64
Copy link
Member

miri64 commented Mar 31, 2015

I heard this got superceded by utlist. Is this correct? If yes: close?

@OlegHahm
Copy link
Member Author

OlegHahm commented Apr 9, 2015

Yes, I think so.

(You're well informed, @authmillenon 😉)

@OlegHahm OlegHahm closed this Apr 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cgundogan cgundogan

Labels

Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@OlegHahm @cgundogan @LudwigKnuepfer @miri64 @benpicco