Small refactor of the interaction system. #1261#1478
Open
rohitkulkarni97 wants to merge 4 commits intoRE-SS3D:developfrom
Open
Small refactor of the interaction system. #1261#1478rohitkulkarni97 wants to merge 4 commits intoRE-SS3D:developfrom
rohitkulkarni97 wants to merge 4 commits intoRE-SS3D:developfrom
Conversation
…rom Interaction class.
…add Name and Icon properties
…mproved interaction handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Interaction.cs class is removed, and default functions have been added to the IInteraction interface. The IInteraction interface has been divided into IDelayedInteraction and IClientInteractionSource interfaces.
PR checklist
Pictures/Videos)
Testing
Networking checklist
Changes
The Interaction class has been removed as it was redundant; instead IInteraction interface has default function implementations which are used.
The IInteraction interface had many unused functions like Update, Cancel, and CreateClients, which were not used by all the classes inheriting from it. Thus, two new interfaces are introduced: IDelayedInteraction for Update and Cancel functions, which are used to handle delayed interactions, and IClientInteractionSource, which has CreateClient function with a default implementation, which is used by different interaction classes to provide ClientInteraction objects.
Related issues/PRs
Closes #1261
Small refactor of the interaction system.