Conversation
Contributor
|
@SotosTsepe can you have a look? |
SotosTsepe
approved these changes
Nov 19, 2025
Collaborator
SotosTsepe
left a comment
SotosTsepe
left a comment
There was a problem hiding this comment.
Approved, workflow is useful as is.
Please address the following comments in a future PR, as these improvements can be handled later:
- Both jobs repeat the steps for checkout and install of the json CLI. Merging into a single job with matrix strategy or using
needs:avoids duplication. - Might be useful to set strict failure with
set -e, so that the job does not continue if one validation fails. - Add
-type ftofindto explicitly match only files. - Maybe relax the pin for the
jsonschematov12.2orv12 - If we are certain that the filenames will not contain any spaces or special characters in the future, then we can leave the logic as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.