added type checks for new_object() argument .parent #503
Open
tschwarzl wants to merge 1 commit intoRConsortium:mainfrom
Open
added type checks for new_object() argument .parent #503tschwarzl wants to merge 1 commit intoRConsortium:mainfrom
tschwarzl wants to merge 1 commit intoRConsortium:mainfrom
Conversation
…nforcing S7_object and prohibiting S7_class passing.
tschwarzl
changed the title
hadley
reviewed
Nov 25, 2024
Member
hadley
left a comment
hadley
left a comment
There was a problem hiding this comment.
Thanks for working on this. This will be a nice improvement in user friendliness.
|
|
||
| #' @param .parent,... Parent object and named properties used to construct the | ||
| #' object. | ||
| #' @param .parent,... Parent S7 object and named properties used to construct |
Member
There was a problem hiding this comment.
This isn't necessarily an S7 object, because the class might extend a base class.
| if (!inherits(.parent, "S7_object")) | ||
| stop("`.parent` needs to be an S7_object") | ||
| if (inherits(.parent, "S7_class")) { | ||
| stop(paste("`.parent` cannot be of type S7_class. Did you type", |
Member
There was a problem hiding this comment.
Can you please put this on two lines and add a snapshot test for it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addressing issue #502
added type checks for
new_object()argument.parentasserting that it is of typeS7 objectnotS7_class