Fix BLE ACL fragmented packet reassembly#34
Open
omicronns wants to merge 1 commit intoRCayre:masterfrom
Open
Conversation
|
I just stumbled on the same problem, and got to the same conclusion. Then I found your PR. Thanks for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe there was a bug in BLE packet reassembly. Current code assumed
L2CAP_Hdrwill be afterHCI_ACL_Hdrin incoming packet fragments, but this is not true. In the next fragments there can be any data which only sometimes will be interpreted byscapyasL2CAP. According to Wireshark's dissector actual fragment data starts afterHCI_ACL_Hdrwhich I extracted usingHCI_ACL_Hdr:][1:].Also both reassembly
ifstatements can be pulled into the conditional immediately after them.