-
Notifications
You must be signed in to change notification settings - Fork 4
Update README.md #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
whmarsh87
wants to merge
31
commits into
RC2-Tools:main
Choose a base branch
from
whmarsh87:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was mostly to condense down the links. I think it makes it a little more readable than having the full html shown.
I might be going off on the weeds, but reading markdown language, ` ` is used for Code. I think these changes should remove things that aren't "code," but "click on," to something other than a Code marker. Maybe that doesn't matter. Idk.
I overlooked Terminal and on second thoughts, the search term would be a typed thing in the search bar (argument for the Code markup)
removed periods for consistency. (I think I'm the one that added any line that had them.)
I might just be going further off in the weeds here
The alignment for the bullet bothered me
This is a take or leave option for viewability. I'm not sure which I like better.
For Java 1.8, there is 8u211-and-later and 8u202-and-earlier. This changes the link into a direct link to 8u211-and-later, which I assume is the version wanted. Unless 8u202-and-earlier also works and/or there is a reason to not directly go to 1.8 since that is the version of Java explicitly stated to be needed.
change for consistency in verbiage
I just didn't like the original verbiage I used. Open to suggestions.
Made the verbiage for Maven and Java similar. Mostly reflects original Java verbiage with a small tweak since it reads better due to the differences in how environmental variables are set. Not 100% sold on this exact verbiage, open to suggestions or I'll think on it more. Just wanted consistency established first.
Fixed typo with "environmental"
At least I consistently missed the 'n'
typos
Consistency since everything else is in bullet form
I just think I like this visually a little better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.