fix(ci): allow cargo package dry run#88
Conversation
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Lines 49 to 52 in 7297536
[P0] Switching to registry deps makes crate unparsable
The manifest now depends on masterror-derive and masterror-template solely by version, but both of those crates are still marked publish = false in their own manifests. Because .cargo/config.toml is not consulted when this package is consumed from crates.io, downstream builds will attempt to download masterror-derive 0.6.0/masterror-template 0.3.1 from the registry and fail with “no matching package found”. Unless these helper crates are actually published, this change makes masterror impossible to build for every external user.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
Summary
masterror-derive/masterror-template, rely on their declared versions and override them locally via.cargo/configinclude, add the config to the package payload, and bump the crate version to 0.10.4Testing
https://chatgpt.com/codex/tasks/task_e_68ce8478e99c832bbb42404d39139d0c