Merged
Conversation
Add missing imports from alloc crate when std feature is disabled: - String in builder.rs (lines 126, 416) - Box in introspection.rs (line 238) - ToString in display.rs (line 391) Also add CI check for no_std builds to prevent future regressions. Fixes #326
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix no_std compilation broken in v0.25.0.
Changes
Add missing
allocimports whenstdfeature is disabled:StringimportBoximportToStringimportRoot Cause
v0.25.0 refactored core modules but missed adding
allocimports for no_std builds.Testing
cargo check --no-default-featurespassesSeverity
Critical - Breaks no_std builds completely
Closes #326