Merged
Conversation
…terns This commit resolves issue #173 by updating the macro code generation to use shorthand field pattern syntax required by Rust 2024 edition. Changes: - Modified error_trait.rs to generate shorthand patterns (field vs field: field) - Added deny directive for non_shorthand_field_patterns in error_derive test - Created new rust_2024_edition.rs test with comprehensive coverage - Fixed telemetry_flushes_after_subscriber_install test race condition All tests pass successfully with Rust 2024 edition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed Rust 2024 edition compatibility by updating macro code generation to use shorthand field pattern syntax.
Changes
error_trait.rsto generate shorthand patterns (fieldvsfield: field) when field name matches binding name#![deny(non_shorthand_field_patterns)]inerror_derive.rstest to ensure compliancerust_2024_edition.rstest covering all pattern scenariostelemetry_flushes_after_subscriber_installtest race conditionTest Plan
cargo +nightly fmtpassescargo clippy --all-targets --all-featurespasses with no warningscargo test --all-features- all 157 tests passcargo build --release --all-featuressucceedsrust_2024_editiontest passes with#![deny(non_shorthand_field_patterns)]error_derivetest passes with deny directiveCloses #173