fix: gate provide shim based on error request support#157
Conversation
There was a problem hiding this comment.
💡 Codex Review
masterror/tests/error_derive.rs
Lines 1 to 6 in 5a78b69
[P1] Enable nightly feature for integration tests
The build script now emits masterror_has_error_generic_member_access together with masterror_requires_error_generic_feature when std::error::Request is only available behind the nightly error_generic_member_access feature. The library crate enables the feature flag via #![cfg_attr(..., feature(error_generic_member_access))], but tests/error_derive.rs does not. Once the new cfg evaluates to true, the #[cfg(masterror_has_error_generic_member_access)] blocks in this file will be compiled and will use std::error::request_* APIs, yet the crate still lacks #![feature(error_generic_member_access)], so the tests will fail to compile on nightly. Add the same conditional #![feature(error_generic_member_access)] at the top of this test module or gate the entire file when the feature is required.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68db4110dcac832ba63fa03479c93ea6