Validate legacy error response statuses#146
Conversation
There was a problem hiding this comment.
💡 Codex Review
masterror/src/response/legacy.rs
Line 16 in a1119ad
[P1] Restore alloc::String import for no_std builds
The diff drops use alloc::string::String, but new_legacy still uses impl Into<String>. That compiles with the default std feature because the standard prelude re‑exports String, yet the crate explicitly supports no_std (#![cfg_attr(not(feature = "std"), no_std)]). When consumers build with --no-default-features, String is no longer in scope and this module fails to compile. Reintroduce the alloc::string::String import or fully qualify the type so the function remains usable in no_std configurations.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
Summary
ErrorResponse::new_legacystatus codes before constructing responsesTesting
https://chatgpt.com/codex/tasks/task_e_68d77de97238832ba4497b48b5fc64bb