Open
Conversation
Added the get for filters (supports years only right now)
Cleaned up tests and endpoints accordingly
but this has at least gotten us up on a new endpoint.
Added a simple test.sh to validate that the new endpoints are functioning.
Recreating deploy.sh as an action, we'll see how this goes.
Will only trigger on published releases
Supposedly Artifact Registry requires this
Should include the -docker.pkg.dev suffix
Stupid line continuations
GH Actions deployment.
tests rather than after to avoid issues with dirty databases.
(filters/pagination), made endpoint export style consistent, fixed a couple of resultant errors in tests.
Also finally got around to separating the test and prod firestore instances
…ral test failures induced by last couple of fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing issues identified by Lesley