Closed
Conversation
- Also makes the creation of messaged for FCM more streamlined.
- Adds kotlin annotation processing - More idiomatic kt in some places
Contributor
|
Has this been tested? I would like to continue development but would like to avoid merge conflicts. |
Member
Author
|
Hi @blootsvoets, thanks for the interest. Would be great to have you continue this further. Yes this has been tested. Although it would have some major conflicts once #85 get merged to dev. I think we should wait till then. |
Member
Author
|
Closing this old PR as it has been superseded by more recent Kotlin refactoring efforts (PR #518). This partial conversion is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, both java and kotlin code interplay.
More than half of the code is converted including the whole fcm library package
org.radarbase.fcmStill pending