Skip to content

Determine how double-width characters render on a given terminal before adjusting chars used for Q logo #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blacks1ne wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Determine how double-width characters render on a given terminal before adjusting chars used for Q logo #455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ func Flags(blockchar **string, ver **string) {
setter{
*blockchar,
*ver,
"\U0001F1EB\U0001F1F7 ",
"\U0001F1EB\U0001F1F7",
Copy link
Contributor

@CassOnMars CassOnMars Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the space there because a lot of the terminal emulators don't correctly handle combining unicode characters correctly, causing it to treat the two unicode points as one character (correct), but has a double width (also correct), but does not apply double width to the character when printing, resulting in overlapping flags. In some cases, terminals need the extra space, in others, they don't. If we're keeping this easter egg for longer than 2.1.0, we should probably find a way to determine how double-width characters render on a given terminal. Note: I don't know if there's a standard way to do that, many terminal emulators have issues that crop up around this from time to time, and are prioritized low or "not fixing" (e.g. microsoft/terminal#16852)

"\U00000047\U0000006F\U0000006F\U00000062\U00000079",
},
"\U00000067\U0000006F\U0000006F\U00000062\U00000079",
Expand Down