Skip to content

Module 06 | React. Forms#6

Open
Quiddlee wants to merge 50 commits intomainfrom
module-06
Open

Module 06 | React. Forms#6
Quiddlee wants to merge 50 commits intomainfrom
module-06

Conversation

@Quiddlee
Copy link
Owner

@Quiddlee Quiddlee commented Dec 3, 2023

  1. Task: click

  2. Screenshot:
    image
    image

  3. Deploy: click

  4. Done 03.12.2023 / deadline 04.12.2023

  5. Score: 100 / 100

Functional requirements 🍿

  • 📍 3 routes (main and 2 routes for forms), Redux is set up and used to collect data from both forms, redirect to main route after submitting the form - 15 points
  • ✌️ Validation works for both forms according to the requirements (error messages, blocking submit button), Yup is used for validation (10 points if works only for one form) - 20 points
  • ✅ Name, age, email, gender picker, accept T&C are implemented for both forms and collect data (if something doesn't work, score can be less) - 20 points
  • 🌌 Input for image is implemented for both forms, image is saved as base64 and dispaly on the main route after redirect - 15 points
  • 🔑 Passwords (with password strength) are implemented for both forms - 15 points
  • 🍂 Autocomplete works for both forms - 15 points Max points should be assigned in case if the requirement has been implemented for both forms, if something doesn't work, score should be less

Penalties 👎

  • 😥 TypeScript isn't used: -95 points
  • 😱 Usage of any: -20 points per each
  • 🙀 Usage of ts-ignore: -20 points per each
  • 🧃 Direct DOM manipulations inside the React components: -50 points per each
  • 🪝 React hooks are used to get access to either state, or to the component lifecycle: -70 points
  • 💨 Presence of code-smells (God-object, chunks of duplicate code), commented code sections: -10 points per each
  • 📚 Usage of component libraries, e.g. Material UI, Ant Design: -100 points
  • 📔 Test coverage is less than 80%: -30 points
  • 📛 Commits after the deadline: -40 points

@Quiddlee Quiddlee requested a review from andron13 December 3, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant