Skip to content

Module 05 | Next.JS | SSR | SSG#5

Open
Quiddlee wants to merge 43 commits intomodule-04from
module-05
Open

Module 05 | Next.JS | SSR | SSG#5
Quiddlee wants to merge 43 commits intomodule-04from
module-05

Conversation

@Quiddlee
Copy link
Owner

  1. Task: click
  2. Screenshot:
    image

image

  1. Deploy: click
  2. Done 26.11.2023 / deadline 27.11.2023
  3. Score: 100 / 100

Functional requirements 🍿

  • 💨 The app migrated to the Next.JS - 25 points
  • 🎈 All retaining functionality works as expected from previous tasks - 25 points
  • 📞 Pages API has been used for all pages - 20 points
  • 📦 All pages with state receive it via getServerSideProps - 10 points
  • 🧪 Tests had been modified to work with SSR - 20 points

Penalties 👎

  • 😥 TypeScript isn't used: -95 points
  • 😱 Usage of any: -20 points per each
  • 🙀 Usage of ts-ignore: -20 points per each
  • 🧃 Direct DOM manipulations inside the React components: -50 points per each
  • 🪝 React hooks are used to get access to either state, or to the component lifecycle: -70 points
  • 💨 Presence of code-smells (God-object, chunks of duplicate code), commented code sections: -10 points per each
  • 📚 Usage of component libraries, e.g. Material UI, Ant Design: -100 points
  • 📔 Test coverage is less than 80%: -30 points
  • 📛 Commits after the deadline: -40 points

Repository owner deleted a comment from vercel bot Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant