Skip to content

Module-01 | React Components#1

Open
Quiddlee wants to merge 74 commits intomainfrom
module-01
Open

Module-01 | React Components#1
Quiddlee wants to merge 74 commits intomainfrom
module-01

Conversation

@Quiddlee
Copy link
Owner

@Quiddlee Quiddlee commented Oct 28, 2023

  1. Task: click
  2. Screenshot:
    image

image

  1. Deploy: click
  2. Done 28.10.2023 / deadline 29.10.2023
  3. Score: 100 / 100

Functional requirements 🍿

  • 🌓 Page is split into 2 sections, top one has Search input and "Search" button, main section displays the list of results from the selected api when page is opened for the first time (loader should be shown while app makes a call to the api) - 20 points
  • 🔍 When user types something to the Search input and clicks "Search" button, a loader is displayed and the list is changed according to the response results for a provided search term - 15 points
  • 📥 The search term typed into the Search input is saved in the local storage when user clicks on "Search" button (check it by closing the tab and open the app in the new one - the initial call should contain previously entered search term) - 15 points
  • 🌋 Application is wrapped with ErrorBoundary, which logs error to a console and shows a fallback UI. There should be a button to throw an error - 10 points

Non-functional requirements 🎬

  • 🧃 Eslint is set up, when lint command is run it doesn't produce any errors (if there are warnings score might be less) - 15 points
  • 🌌 Prettier is set up, format:fix command fixes issues - 15 points
  • 🧹 Husky is set up, linting is run on pre-commit - 10 points

Penalties 👎

  • TypeScript isn't used: -95 points
  • Usage of any: -20 points per each
  • Usage of ts-ignore: -20 points per each
  • Direct DOM manipulations inside the React components: -50 points per each
  • React hooks are used to get access to either state, or to the component lifecycle: -70 points
  • Presence of code-smells (God-object, chunks of duplicate code), commented code sections: -10 points per each
  • Usage of Redux or other state management libraries: -100 points
  • Usage of component libraries, e.g. Material UI, Ant Design: -100 points

Copy link
Collaborator

@andron13 andron13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Как всегда всё круто

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants