Fix steer vault in pool page #1708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameepsi
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 4 vaults available for the selected pool (QuickNew + POL):
Pool Address: 0x9f1a8caf3c8e94e43aa64922d67dff4dc3e88a42
Vault 1 Address: 0x8b7dc6bb6e3d8fc3edd349403fab787ed6ed8003
Vault 2 Address: 0x9159ad3aedd8ce0e7f4ee7e817737c7fc80d2cf0
Vault 3 Address: 0xa92700fd49cc339faa88d53d2cf58c0f1b429446
Vault 4 Address: 0xf626514a3b5b7670e5d3cb2b6533e5eb4b3a9e9c
Vaults 1, 2, and 3 contain invalid addresses, while Vault 4 is valid.
As a result, the 3 invalid vaults showed "Out of Range" errors. When the setting is changed to "Narrow," the vault APR is displayed correctly (greater than 0).
This PR fixed an issue where, even after selecting "Narrow," the APR for Steer's vault was not shown. This happened because the contracts for Vaults 1, 2, and 3 are invalid, so the tick amounts were set to undefined.
Added code to hide the invalid Steer vaults to resolve this issue.