Fix "Argument list too long" error when linking modules with many object files #383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling modules with hundreds of
.ofiles, ninja fails withposix_spawn: Argument list too longbecause command-line arguments exceed OS limits (~128KB).Changes
New:
scripts/compilation/fix_ninja_response_files.py@filesyntax)$inwith@$out.rspand addsrspfile/rspfile_contentdirectives\$in(?=\s|$|[^a-zA-Z0-9_])to avoid matching$include_dirand similar variablesModified:
scripts/compilation/qp_create_ninja&&chaining to fail build if post-processing failsExample
Before (causes error with many files):
After (uses response file):
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
gitlab.com/usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.