76 allow merging of pp terms and extend ct interface to allow discretized angles #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ectras
reviewed
Nov 27, 2025
added 7 commits
November 27, 2025 14:24
Only expose single function that actually merges to avoid exposing internal data stuctures.
Rename Angle::Angle to Angle::Arbitrary. Set to as it doesn't need a larger int.
keefehuang
force-pushed
the
76-allow-merging-of-pp-terms-and-extend-ct-interface-to-allow-discretized-angles
branch
from
9f1bea8 to
fc7ec2f
Compare
Contributor
|
These changes got merge already with a different MR, but we do need to add Manu's suggestions still to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented new enum Angle type that takes either a float or a pi/4 rotation.
Implemented algorithm to find and merge PauliGadgets with the same Paulistring. Currently, merging float / pi/4 rotation not supported.
Added algorithm to update CT with Clifford PauliGadget with tests