chore: Remove lib.rs and move behavior tests from integration to unit tests #59
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| register_behavior_tests!( | ||
| test_head_default_10_lines, | ||
| test_head_n_lines, | ||
| test_head_nonexistent_file, |
There was a problem hiding this comment.
The new unit-test harness only registers three head behavior cases (test_head_default_10_lines, test_head_n_lines, and test_head_nonexistent_file). The previous integration suite also exercised byte-based reads (head -c), zero-length handling, and multi-file output/quiet flags, so those options are no longer covered after this move. That drop in coverage means regressions in head’s byte-counting and multi-file output formatting will now slip through unchecked. Please migrate the missing cases into the new suite.
Useful? React with 👍 / 👎.
| register_behavior_tests!( | ||
| test_tail_default_10_lines, | ||
| test_tail_n_lines, | ||
| test_tail_nonexistent_file, |
There was a problem hiding this comment.
Similarly, the refactored tail behavior tests now cover only the default 10-line case, a -n count, and a missing file, dropping the byte-count (-c), zero-length, and multi-file quiet/verbose scenarios that were present in the old integration suite. With those cases gone, regressions in byte-based tails and multi-file header handling will no longer be detected when the behavior suite runs. Consider porting the missing tests to the new unit-test harness.
Useful? React with 👍 / 👎.
Refer to a related PR or issue link (optional)
This commit relocates the behavior test suite from integration tests
to unit tests within the main crate. The changes include:
Cargo.tomlto remove the behavior test configurationThe behavior tests now run as part of
cargo testand can be skippedby setting the STORIFY_SKIP_BEHAVIOR environment variable.
What's changed and what's your intention?
PR Checklist
Please convert it to a draft if some of the following conditions are not met.