Add axes selection to measure and EPR create PMG calls #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thom747
commented
Jan 26, 2026
| EprMeasBasis.X: (24, 0, 0), | ||
| EprMeasBasis.Y: (8, 24, 24), | ||
| EprMeasBasis.Z: (0, 0, 0), | ||
| # FIXME: Check with Bart what the correct decompositions are for the negative bases. |
Contributor
Author
There was a problem hiding this comment.
@bvdvecht Could you provide me with the correct decompositions?
Thom747
commented
Jan 26, 2026
| EprMeasBasis.X: (24, 24, 8), | ||
| EprMeasBasis.Y: (0, 8, 0), | ||
| EprMeasBasis.Z: (0, 0, 0), | ||
| # FIXME: Check with Bart what the correct decompositions are for the negative bases. |
Contributor
Author
There was a problem hiding this comment.
@bvdvecht Could you provide me with the correct decompositions?
Thom747
commented
Jan 26, 2026
| qubit_reg: operand.Register, | ||
| params: EntRequestParams, | ||
| ) -> None: | ||
| # FIXME: Figure out with Bart what the versions of these corrections is for YZY and ZXZ. |
Contributor
Author
There was a problem hiding this comment.
@bvdvecht Could you provide me with the correct decompositions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to select the axes that a particular pre-measurement gate (PMG) should rotate around.
This is needed, as for some platforms (such as NV) it is more performant to rotate around certain axes than others.
For the Measure command, it was not possible to add this functionality to the encoding without breaking backwards-compatiblity.
Thus, for that command two new opcodes have been added that encode the axes in the opcode.
Back-end maintainers should thus add support for these new opcodes, but will remain compatible with any code that does not make use of them.
For EPR Create, the parameter array was extended by two so that the axes could be encoded in there.
This is thus fully backwards-compatible.
This PR also cleans up a bit of the code I was working in.
This is a redo of a previously reverted feature, see also #76.