Lambda Comp lowering #588
Open
Lambda Comp lowering #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Contributor
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Roger-luo
reviewed
Dec 9, 2025
| func_frame.exhaust() | ||
|
|
||
| last_stmt = func_frame.curr_region.blocks[0].last_stmt | ||
| rtrn_stmt = func.Return(last_stmt.result) |
Collaborator
There was a problem hiding this comment.
can you add comment if you are certain the last_stmt.result won't be None? and make pyright happy about it using ignore? Or we should add a check here.
Collaborator
Author
There was a problem hiding this comment.
for listcomp it should always have a return so it shouldn't be None. let me take a look to see what I can do
Roger-luo
reviewed
Dec 9, 2025
| @@ -0,0 +1,64 @@ | |||
| from kirin import ir | |||
Collaborator
There was a problem hiding this comment.
can we remove the comp this is not about lambda in list comprehension?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address #525