Skip to content

Adding Display Specifiers objects analysis#3

Open
Fanaw wants to merge 1 commit intoQazeer:mainfrom
Fanaw:dev
Open

Adding Display Specifiers objects analysis#3
Fanaw wants to merge 1 commit intoQazeer:mainfrom
Fanaw:dev

Conversation

@Fanaw
Copy link
Copy Markdown
Contributor

@Fanaw Fanaw commented Oct 2, 2023

This PR adds analysis of Display Specifier objects in the Configuration naming context.

Modified Display Specifiers can add new menu contexts in the ADUC admin tool, which may make execute arbitrary code unwittingly to administrators.

Here is an example when the user-Display Display Specifier is modified:
image
image
image
(Remote files can also be executed this way).

This PR compares current values of adminContextMenu of every Display Specifier to extracted default values.
When there is a mismatch, it is reported as output like other commands (example in JSON format):
image

@Fanaw
Copy link
Copy Markdown
Contributor Author

Fanaw commented Oct 4, 2023

After running this function in a real AD environement, I realized Display Modifier values are MUCH more heterogeneous than a default AD. I am going to review my code to check if dangerous files could be run through DM instead of comparing to default values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant