Fix deathtype field parsing to prevent 64-bit memory overwrite#443
Merged
Fix deathtype field parsing to prevent 64-bit memory overwrite#443
Conversation
The spawn field table listed "deathtype" as F_LSTRING, so G_ParseField was writing a char* into an int slot. On 64-bit builds this wrote 8 bytes, which corrupted both deathtype (lower 32 bits of the pointer) and the next field (dmgtime, upper 32 bits). This could lead to random deathtype values and clobbered dmgtime, causing incorrect logic and potential crashes. We now ignore the "deathtype" spawn key to avoid writing a pointer into an integer field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spawn field table listed "deathtype" as F_LSTRING, so G_ParseField was writing a char* into an int slot.
On 64-bit builds this wrote 8 bytes, which corrupted both deathtype (lower 32 bits of the pointer) and the next field (dmgtime, upper 32 bits).
This could lead to random deathtype values and clobbered dmgtime, causing incorrect logic and potential crashes.
We now ignore the "deathtype" spawn key to avoid writing a pointer into an integer field.