Merged
Conversation
Bumps Pico1 array size from 243kB to 244kB Pico2 array size is nominally 500kB
counts how many non-zero ones, and exits if the answer is not 0. Probably.
Json-To-String
previously approved these changes
Apr 17, 2025
Collaborator
Json-To-String
left a comment
Json-To-String
left a comment
There was a problem hiding this comment.
LGTM, tested and works on my setup
Collaborator
|
actually I may have gotten a tad hasty - I should have ran |
Json-To-String
approved these changes
Apr 17, 2025
Contributor
Author
|
Decided not to increase the internal timer limit from 5000 for the RP2350 as a simplification and because 5000 seems like plenty for what we typically use as a debug system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the SDK to 2.1.1 and adds nominal support for the Pico 2 board. Primary gain is the larger SRAM, which allows for 500kB of instruction memory.
Note: this PR also bumps up the RP2040 instruction memory from 243kB to 244kB as there was a tiny bit of room left.
Bumps the version to 0.4.0 and adds a
boardcommand to query which board is being used.Testing is underway to confirm max instruction number, at which point we can update the README.