Conversation
…, saving progress
…an the downwards, need to fix
… enforce the denominator to be 1? I believe thats the same as before, but outskirts the bounds on get_asf()
…anup on comments in dds-sweeper.c
Json-To-String
commented
Apr 7, 2025
dihm
requested changes
Apr 7, 2025
Contributor
dihm
left a comment
dihm
left a comment
There was a problem hiding this comment.
We should update the definition of sweep rate for the set commands and ensure the definition of sweep rate for seti/setb are correct/consistent.
Note: did not look at the notebooks.
Collaborator
Author
|
Actually I realize I still need to add a bit to the README about the ramps |
…seti and setb should be correct, + describe conversion process in SWEEP_DETAILS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the continued fraction algorithm to determine a better integer ratio for sweeps by attempting to approximate the double provided by the user for
sweep_rate.The algorithm gets added to
ad9959.cin the functionsapprox_double_32andapprox_double_16to reduce clutter in the maindds-sweeper.cfile, and modifies only thesetcommand by changing logic in theparse_{amp, phase, freq}_insfunctions.The implementation attempts to respect the maximum and minimum integer values each tuning word (amp, phase, freq) can be.
To handle downward sweeps, the algorithm's maximum
rateor denominator that it returns is set to 1.