Max instruction counting / verifying#72
Merged
dihm merged 14 commits intoQTC-UMD:mainfrom Apr 9, 2025
Merged
Conversation
Json-To-String
commented
Apr 8, 2025
dihm
requested changes
Apr 9, 2025
Contributor
dihm
left a comment
dihm
left a comment
There was a problem hiding this comment.
Little bit of tidying up, but otherwise this looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to tackle #71
When trying to lower the
MAX_SIZEvariable to deal with the differences between the amount of instructions that would fit in memory vs the amount that would actually trigger, I think I got lucky on that fixing things for one mode in particular. I suspect that the disagreement comes from byte (mis)alignment since some of our instructions aren't even lengths. Although I suppose that wouldn't necessarily explain single stepping, since each instruction is 14 bytes (but still not a power of 2).If this is the reason why, we could maybe fix this with adding padding bytes to the instructions? But this seems pretty cumbersome and maybe not worth the hassle.
Regardless, the
instruction-counting.ipynbnotebook shows at least why each instruction count ballparks to a particular value, andinstruction-tests.ipynballows us to search for the exact number. I started to write a semi-automated test for that but that also seemed like a rabbit hole. If necessary, I can generalize that.