Conversation
✅ Deploy Preview for zcash-zips-qedit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
vivek-arte
force-pushed
the
asset_swaps
branch
from
79b61be to
d201167
Compare
vivek-arte
force-pushed
the
asset_swaps
branch
2 times, most recently
from
122a4f6 to
2c3898a
Compare
vivek-arte
added a commit
that referenced
this pull request
Sep 17, 2024
This makes updates based on the comments made on #50.
vivek-arte
added a commit
that referenced
this pull request
Sep 30, 2024
This makes updates based on the comments made on #50.
vivek-arte
force-pushed
the
asset_swaps
branch
from
2786578 to
41b606a
Compare
vivek-arte
added a commit
that referenced
this pull request
Jun 9, 2025
This makes updates based on the comments made on #50.
ConstanceBeguier
left a comment
ConstanceBeguier
left a comment
There was a problem hiding this comment.
Some comments to update this ZIP with last modifications in other ZIPs
- Replace timelimit with AGExpiryHeight
- Add a section to explain that ActionGroup and AGExpiryHeight have already been included in NU7 to avoid a transaction format modification.
- Should we create a new sighash version for Swap?
This makes updates based on the comments made on #50.
In swap bundle figure, - replace spend and output notes by actions - fix bundle value balance
- fix global bundle value balance by adding fees - remove action fields (cv_net, nf, rk, cm_x, epk, ...) for each action - remove global transaction fields (header, nVersionGroupId, nConsensusBranchId, tx_in_account, ...)
Replace split notes by reference notes Replace timeLimit by expiryHeight
This PR goes through ZIP 228, and makes changes to reconcile the ZIP with the updates made in ZIP 226, ZIP 227, ZIP 230 and ZIP 246, for the NU7 protocol upgrade.
vivek-arte
force-pushed
the
asset_swaps
branch
from
65e446b to
97c07d5
Compare
✅ Deploy Preview for zcash-zips-qedit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a reference of the changes made for ZSA Swaps above the changes for the ZSA Protocol. The upstream PR for the same is zcash#780.
The changes are majorly in ZIP 228: Zcash Shielded Asset Swaps, with minor changes in the README.rst file to add the new ZIP to the index.