Allow finalizing issued assets via the issue action when no notes are provided#36
Closed
dmidem wants to merge 5 commits intozsa-integration-statefrom
Closed
Allow finalizing issued assets via the issue action when no notes are provided#36dmidem wants to merge 5 commits intozsa-integration-statefrom
dmidem wants to merge 5 commits intozsa-integration-statefrom
Conversation
… provided and the finalize flag is set to true
…_WORKFLOW_BLOCKS for multiple workflows in orchard_zsa test vectors of zebra-test crate
Collaborator
Author
|
Closed in favor of #29, as these changes have been merged there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the modified
zebra-statecrate issued assets could only be finalized via an issue action if the action included at least one note. However, the specification does not require issue actions to have notes, meaning finalization should be possible even when no notes are provided.This PR modifies the finalization logic to allow assets to be finalized when the finalize flag is set to true in the issue action, regardless of the presence of notes.