Tracks issued assets state and contextually validates issue actions and asset burns#26
Closed
arya2 wants to merge 10 commits intozsa-integration-issuance-commitmentsfrom
Closed
Tracks issued assets state and contextually validates issue actions and asset burns#26arya2 wants to merge 10 commits intozsa-integration-issuance-commitmentsfrom
arya2 wants to merge 10 commits intozsa-integration-issuance-commitmentsfrom
Conversation
9f5cb45 to
3d00b81
Compare
902bfa6 to
44dd204
Compare
44dd204 to
2daf84f
Compare
arya2
commented
Nov 12, 2024
zebra-state/src/service/finalized_state/disk_format/shielded.rs
Outdated
Show resolved
Hide resolved
…callyVerifiedBlock types, updates `IssuedAssetsChange::from_transactions()` method return type
…heckpointVerifiedBlock
arya2
commented
Feb 6, 2025
| self.issued_assets.get(asset_base).cloned() | ||
| } | ||
|
|
||
| /// Remove the History tree index at `height`. |
Collaborator
Author
There was a problem hiding this comment.
@dmidem I think it would be simpler to keep the issued assets maps on each ContextuallyValidatedBlock partial relative to the previous block instead of making them partial relative to the finalized tip, but if they need to be relative to the finalized tip, copying the AssetBases for every block would multiply the non-finalized state's theoretical max memory use, so those should go in Arcs.
Suggested change
| /// Remove the History tree index at `height`. | |
| /// When a block with the provided `transactions` and partial `issued_assets` state is removed | |
| /// from the chain tip, revert its changes from the [`Chain`]'s partial issued assets state. | |
| /// | |
| /// When a block is removed from the chain root to be committed to the finalized state, any | |
| /// assets in its partial `issued_assets` with an asset state matching the one in the chain's | |
| /// partial issued assets map is removed from the chain's partial issued assets map (since that | |
| /// it should match the finalized issued asset state.) |
Collaborator
|
Closed in favor of #29. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tracks issued assets in Zebra's state and uses that state to contextually validate issue actions and asset burns.
It still needs tests, additional documentation, cleanup, and to track information for creating split notes.
Review
This PR may be easier to review by commit.