Open
Conversation
PaulLaux
reviewed
Feb 23, 2026
Contributor
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
Overall good. added comments
|
|
||
| /// Like `random`, but the wallet seed is derived from `uniqueness` (e.g. a timestamp) | ||
| /// so that each test run gets a deterministic, unique wallet and avoids conflicts with cached blocks. | ||
| pub fn random_with_uniqueness(miner_seed_phrase: &String, uniqueness: u64) -> Self { |
Contributor
There was a problem hiding this comment.
avoid duplication by adding an optional parameter and functionality to random()
Comment on lines
+179
to
+186
| let mut seed_random_bytes = [0u8; 64]; | ||
| seed_random_bytes[..8].copy_from_slice(&uniqueness.to_le_bytes()); | ||
| // Fill the rest with a simple deterministic expansion so different uniqueness values | ||
| // produce different seeds. | ||
| for i in 8..64 { | ||
| seed_random_bytes[i] = seed_random_bytes[i % 8].wrapping_add(i as u8); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
just hash the seed to 64 bytes instead of this logic.
|
|
||
| /// Like `random`, but the wallet seed is derived from `uniqueness` (e.g. a timestamp) | ||
| /// so that each test run gets a deterministic, unique wallet and avoids conflicts with cached blocks. | ||
| pub fn random_with_uniqueness(miner_seed_phrase: &String, uniqueness: u64) -> Self { |
Contributor
There was a problem hiding this comment.
uniqueness is rearly used. let's call it random_seed
Contributor
|
Also, please update PR description (all open Prs) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.