Fixing failed CI google tests in zsa-integration branch#17
Open
dmidem wants to merge 4 commits intozsa-integrationfrom
Open
Fixing failed CI google tests in zsa-integration branch#17dmidem wants to merge 4 commits intozsa-integrationfrom
dmidem wants to merge 4 commits intozsa-integrationfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses failed CI tests in the
zsa-integrationbranch. The changes include resolvingbad_optional_accessand segmentation faults in specific google tests. Additionally, adjustments to theorchardproof base size have been made to fix two related gtests. Furthermore, two google tests requiring fee fixes forZSAtransfers have been temporarily disabled.It's important to note that while this PR brings the Google tests to a passing state, Boost and Python tests remain to be addressed.