Conversation
…ddleware Replace local-only verifyPayment call in withX402 and checkPayment with processPayment/verifyWithFacilitator from facilitator.ts. Previously the middleware only validated the EIP-3009 signature format locally — no on-chain settlement occurred. Now the full flow runs: 1. verifyWithFacilitator (POST /verify to x402.org/facilitator) 2. execute handler 3. settleWithFacilitator (POST /settle → broadcasts transferWithAuthorization on-chain) Settlement tx hash is logged to stderr when available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withX402in the MCP middleware was calling the localverifyPaymentfunction (signature format + business rules check only) — no on-chain settlement ever occurredprocessPaymentfromfacilitator.tswhich runs the full flow:POST /verify→ execute handler →POST /settle(broadcaststransferWithAuthorizationon-chain)checkPaymentupdated to useverifyWithFacilitatorfor consistencyTest plan
paymentSignatureRecreated from #15 which was accidentally closed