WIP: Upgrade render-engine (and other dependencies) #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonafato
force-pushed
the
upgrade-render-engine
branch
from
b2eb21f to
649f756
Compare
This is most of what's needed to upgrade to the latest beta release of render-engine. Known issues: - Setting the jinja environment undefined handler to StrictUndefined seems to have broken rss rendering - The rss feed name override behavior has stopped working - Archive pages are missing their url at time of generation, so the archive list page links back to itself (href="") instead of to the correct posts
jonafato
force-pushed
the
upgrade-render-engine
branch
from
649f756 to
106b181
Compare
This attribute used to be "feed", but some recent update to render-engine has capitalized the first letter.
jonafato
added a commit
to jonafato/render_engine
that referenced
this pull request
Apr 5, 2023
These templates used to work when using the StrictUndefined undefined behavior in the jinja2 environment, but in recent releases, this causes the build to fail. This issue can be seen at Python-Community-News/Site#38. Using the `is defined` test results in similar behavior even when `StrictUndefined` is set, allowing site developers to catch typos or other missing template context without breaking their rss feeds. This change also includes a new test and a test fixture to create a jinja2 environment that can be modified with the scope of a single test.
jonafato
added a commit
to jonafato/render_engine
that referenced
this pull request
Apr 5, 2023
These templates used to work when using the StrictUndefined undefined behavior in the jinja2 environment, but in recent releases, this causes the build to fail. This issue can be seen at Python-Community-News/Site#38. Using the `is defined` test results in similar behavior even when `StrictUndefined` is set, allowing site developers to catch typos or other missing template context without breaking their rss feeds. This change also includes a new test and a test fixture to create a jinja2 environment that can be modified with the scope of a single test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is most of what's needed to upgrade to the latest beta release of render-engine. Known issues:
Setting the jinja environment undefined handler to StrictUndefined seems to have broken rss rendering
The rss feed name override behavior has stopped working
- Archive pages are missing their url at time of generation, so the archive list page links back to itself (href="") instead of to the correct posts