Replace config.set_request_property by config.add_request_method#31
Closed
arnaud-morvan wants to merge 1 commit intoPylons:masterfrom
Closed
Replace config.set_request_property by config.add_request_method#31arnaud-morvan wants to merge 1 commit intoPylons:masterfrom
arnaud-morvan wants to merge 1 commit intoPylons:masterfrom
Conversation
mmerickel
approved these changes
Apr 8, 2020
Member
|
@arnaud-morvan there is a failing test in the build that needs to be fixed. |
For compatibility with pyramid 1.10
arnaud-morvan
force-pushed
the
fix_pyramid_1.10
branch
from
cb4c2be to
ba8e3f1
Compare
Author
|
@mmerickel @stevepiercy : Thanks for review, I fixed the test, seems that pep8 errors are not related with the PR but already in master. |
Member
|
Would you mind rebasing this change on master? |
Member
|
Actually I believe this was fixed in #33, please re-open if not the case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For compatibility with pyramid 1.10