Skip to content

Escape login identifier before searching the entry. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lmctv wants to merge 1 commit into from
Closed

Escape login identifier before searching the entry. #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pyramid_ldap/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
try:
import ldap
import ldap.filter
except ImportError: # pragma: no cover
# this is for benefit of being able to build the docs on rtd.org
class ldap(object):
Expand Down Expand Up @@ -113,8 +114,10 @@ def authenticate(self, login, password):
if search is None:
raise ConfigurationError(
'ldap_set_login_query was not called during setup')

result = search.execute(conn, login=login, password=password)

escaped_login = ldap.filter.escape_filter_chars(login)

result = search.execute(conn, login=escaped_login, password=password)
if len(result) == 1:
login_dn = result[0][0]
else:
Expand Down