core.job.submission: Fix memory_per_gpu#403
Merged
tazend merged 1 commit intoPySlurm:mainfrom Mar 14, 2026
Merged
Conversation
Member
|
Hey, thank you, that indeed looks like some mistake introduced when refactoring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered a bug today while trying to control GPU memory allocation that seems to be the result of a copy/paste (or perhaps refactoring) error. This patch seems to give the expected behavior.
This bug dates back nearly three years; I've backported it to 24.05 for my own use but am not sure what the general backport policy is.