Merged
Conversation
- changed test() method in criteria - moved time counting to ext package
- added generator hierarchy - time handler corrected - removed _ext_package folder with usages updated
…grated some old ones)
…l and exponentiality support)
…port and stubs for exponentiality) + added some missed files
Exponentially + refactoring of architecture
# Conflicts: # stattest/execution/data.py # stattest/execution/execution.py # stattest/test/common.py # stattest/test/normal.py # tests/normality/ad_test.py # tests/normality/bhs_test.py # tests/normality/da_test.py # tests/normality/lilliefors_test.py # tests/normality/swm_test.py # tests/normality/zhang_wu_a_test.py # tests/weibull/ad_weibull_test.py # tests/weibull/ks_weibull_test.py # tests/weibull/los_weibull_test.py # tests/weibull/msf_weibull_test.py # tests/weibull/ok_weibull_test.py # tests/weibull/rejg_weibull_test.py # tests/weibull/rsb_weibull_test.py # tests/weibull/sb_weibull_test.py # tests/weibull/spp_weibull_test.py # tests/weibull/st1_weibull_test.py # tests/weibull/st2_weibull_test.py # tests/weibull/ts_weibull_test.py
f1i3g3
reviewed
Nov 28, 2024
Contributor
f1i3g3
left a comment
f1i3g3
left a comment
There was a problem hiding this comment.
Мне еще не нравится, что PyCharm ругается в двух местах в config_schema.py.
А так вроде все ок.
| pass | ||
|
|
||
| def init(self, **kwargs): | ||
| def init(self): |
Contributor
There was a problem hiding this comment.
def init(self):
"""
Initialize store.
"""
pass
Точно стоит здесь удалять **kwargs в аргументе? Там же тогда сигнатура методов совпадать не будет.
Contributor
There was a problem hiding this comment.
Видимо, тогда остальные тесты тоже стоит в один файл занести (это я себе на будущее).
|
|
||
| from stattest.test.models import AbstractTestStatistic | ||
| from stattest.persistence.json_store.cache import MonteCarloCacheService | ||
| from abc import ABC |
Contributor
There was a problem hiding this comment.
from abc import ABC
Это либа какая-то?
Contributor
Author
There was a problem hiding this comment.
Нет, это встроенное в питон
Contributor
There was a problem hiding this comment.
My bad, это нужно для абстрактных классов - а мне нужно еще покурить синтаксис
f1i3g3
approved these changes
Nov 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Major code refactoring
Link to original pull request: alex98247/statistic-test#4
What's new?