Merged
Conversation
wrdxwrdxwrdx
force-pushed
the
distribution/sampling
branch
2 times, most recently
from
a1de7e9 to
d8ff3f0
Compare
LeonidElkin
reviewed
Feb 23, 2026
Collaborator
LeonidElkin
left a comment
LeonidElkin
left a comment
There was a problem hiding this comment.
Reviewed only core/* except for _unuran_sampler
src/pysatl_core/sampling/unuran/core/unuran_sampling_strategy.py
Outdated
Show resolved
Hide resolved
LeonidElkin
added
API: Design
ALG: Sampling
LeonidElkin
reviewed
Feb 25, 2026
Collaborator
LeonidElkin
left a comment
LeonidElkin
left a comment
There was a problem hiding this comment.
Implement tests as packages with __init__.py
src/pysatl_core/sampling/unuran/core/_unuran_sampler/initialization.py
Outdated
Show resolved
Hide resolved
src/pysatl_core/sampling/unuran/core/_unuran_sampler/initialization.py
Outdated
Show resolved
Hide resolved
src/pysatl_core/sampling/unuran/core/_unuran_sampler/initialization.py
Outdated
Show resolved
Hide resolved
src/pysatl_core/sampling/unuran/core/_unuran_sampler/initialization.py
Outdated
Show resolved
Hide resolved
src/pysatl_core/sampling/unuran/core/_unuran_sampler/callbacks.py
Outdated
Show resolved
Hide resolved
Collaborator
|
Rename |
wrdxwrdxwrdx
force-pushed
the
distribution/sampling
branch
2 times, most recently
from
1478930 to
cd12314
Compare
wrdxwrdxwrdx
force-pushed
the
distribution/sampling
branch
from
cd12314 to
5c22a36
Compare
LeonidElkin
requested changes
Mar 3, 2026
src/pysatl_core/sampling/unuran/core/unuran_sampling_strategy.py
Outdated
Show resolved
Hide resolved
wrdxwrdxwrdx
force-pushed
the
distribution/sampling
branch
5 times, most recently
from
9d8e821 to
fa8b337
Compare
wrdxwrdxwrdx
force-pushed
the
distribution/sampling
branch
3 times, most recently
from
a75d898 to
568f0f6
Compare
LeonidElkin
reviewed
Mar 12, 2026
src/pysatl_core/sampling/unuran/core/_unuran_sampler/callbacks.py
Outdated
Show resolved
Hide resolved
tests/unit/sampling/unuran/core/_unuran_sampler/test_callbacks.py
Outdated
Show resolved
Hide resolved
tests/unit/sampling/unuran/core/_unuran_sampler/test_callbacks.py
Outdated
Show resolved
Hide resolved
tests/unit/sampling/unuran/core/_unuran_sampler/test_callbacks.py
Outdated
Show resolved
Hide resolved
wrdxwrdxwrdx
force-pushed
the
distribution/sampling
branch
from
568f0f6 to
2e0c39b
Compare
Desiment
reviewed
Mar 14, 2026
Desiment
previously approved these changes
Mar 15, 2026
wrdxwrdxwrdx
force-pushed
the
distribution/sampling
branch
from
ca5a196 to
5beffc9
Compare
wrdxwrdxwrdx
force-pushed
the
distribution/sampling
branch
from
99e0093 to
5beffc9
Compare
wrdxwrdxwrdx
force-pushed
the
distribution/sampling
branch
from
5beffc9 to
38e83a4
Compare
LeonidElkin
approved these changes
Mar 17, 2026
Collaborator
LeonidElkin
left a comment
LeonidElkin
left a comment
There was a problem hiding this comment.
LGTM. Very good job! Well done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UNU.RAN integration
Start with notebooks and scripts under
examples/—they showcase end-to-end scenarios for the new sampling strategy.Now you need to run this after git clone
git submodule update --init --remote --recursiveNow unuran submodule cloning from dev branch. Please review PR
WARNING
Added dpdf to registry. This is done due to the fact that many methods require it to work. In the future, it's worth implementing it more correctly in the registry.
Platforms
Added
Characteristics & methods