Conversation
Contributor
Desiment
commented
Apr 28, 2025
Desiment
commented
- Fix mypy
- Fix poetry
- Clean-up
- Renamed classes
project uses poetry, so this file actually not needed ooetry needs only poetry.lock and pyproject.toml
we do not need pipenv, as we should use poetry for packaging purposes (see poetry docs on this)
It seems to be a bug, that poetry does not allow for uppercase and dash symbol in package name, (see related issue), so package was renamed to `cfinversion`. Related: python-poetry/poetry#8662
a few small changes: * removed pytest from requirements (leaving it only in dev group) * add jupyter-notebook dependency to dev group
Removed naive implementation of bohman methods. These implementations do not satisfy interface (in type-hints), and do not use NumPy, so they are quite slow, but have same precision.
It is not possible to implement Pareto distribution using only scipy.special functions lib, because gammainc do not support complex-valued argument. Removed incorrect implementation.
removed files for cauchy and lognormal distributions, as they were empty
Renamed files related to inversion of charteristic functions to follow PySATL-CPD style. Add imports to __init__.py files
* Renamed distribution related files to follow PySATL-CPD style. * Rename Unif to Uniform * Add squared uniform distribution
Value of S(t, x) = Imag[exp(itx) * phi(t) / (it)] is undefined at t = 0; Given that phi'(0) = 0 (which is done via Standardizer), one can assume that at t = 0 S(0, x) = -x, see https://arxiv.org/pdf/1701.08299 eq. 24
At poin t = 0 chr(t) should be 1, but previous implementation encountered division by zero trying evaluate cf at this point.
Now, fit may take unstandardized cf, and cdf should work fine. Method named ``cdf_`` reffers to implementation for standaridized variant
This was kind of useless, should add protocol instead
lilyreber
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.