Feat/docker support multi platform #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om/PyPtt/ptt_mcp_server into feat/docker-support-multi-platform # Conflicts: # Dockerfile
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds multi-platform Docker support by updating the base image, image references, and CI workflow to build for multiple architectures.
- Reference Docker image names in README updated to lowercase
- Switch Dockerfile base image from Debian slim to Alpine on Python 3.12
- GitHub Actions workflow now sets up QEMU, Buildx, and builds for amd64 and arm64
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Fixed image repository casing to lowercase |
| Dockerfile | Changed base image to python:3.12-alpine |
| .github/workflows/deploy.yml | Added QEMU/Buildx setup and multi-platform build step |
Comments suppressed due to low confidence (2)
README.md:44
- [nitpick] Add a note in the README about multi-platform support, e.g. outlining that
linux/amd64andlinux/arm64images will be published and how to pull specific platform variants.
"ghcr.io/pyptt/ptt_mcp_server:latest"
Dockerfile:2
- Ensure required build dependencies (e.g.,
build-base,gcc,musl-dev) are installed if any Python C extensions or native modules need compilation in the Alpine image.
FROM python:3.12-alpine
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.