Merged
Conversation
Icxolu
force-pushed
the
pyo3/0.27
branch
2 times, most recently
from
add5aa6 to
7c74173
Compare
Icxolu
force-pushed
the
pyo3/0.27
branch
2 times, most recently
from
2a9e59d to
9576a65
Compare
jakelishman
approved these changes
Oct 20, 2025
Contributor
jakelishman
left a comment
jakelishman
left a comment
There was a problem hiding this comment.
I successfully tested this PR against Qiskit's test suite (Qiskit/qiskit#15213), which uses a bunch of the conversions. Fwiw, I reviewed the changes and it looks correct to me.
Member
Author
|
Thanks for testing and reviewing, much appreciated! |
|
I tested this with our company internal codebase that uses pyo3/numpy. And all our unit tests pass with it. |
|
It would be great to get this merged and have a new |
Member
Author
|
Thanks all for testing! I think the feedback is sufficiently positive, lets merge and ship. |
Member
Author
|
Release is live now 🎉 |
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades to PyO3 0.27, PyO3/pyo3#5390
FromPyObjectimplsThis still needsPyO3/pyo3#5475Borrowed::castto be made public.