add API to set rpath for libpython from build scripts#5624
Merged
davidhewitt merged 4 commits intoPyO3:mainfrom Nov 29, 2025
Merged
add API to set rpath for libpython from build scripts#5624davidhewitt merged 4 commits intoPyO3:mainfrom
davidhewitt merged 4 commits intoPyO3:mainfrom
Conversation
Member
Author
|
Anyone got concerns with this? Otherwise I'll merge to unblock #5588 |
Icxolu
reviewed
Nov 29, 2025
Contributor
Icxolu
left a comment
Icxolu
left a comment
There was a problem hiding this comment.
Sounds reasonable to me. I assume this flag is simply ignored on windows, as I don't think there is an equivalent to rpath there. Or should we gate it behind an not(windows) anyway?
Member
Author
|
It seems like it just works: https://github.com/PyO3/pyo3/actions/runs/19465508572/job/55701947465 - built and ran ffi check fine on Windows. If it turns out to be a problem later, we can internally make it a noop on windows, which will be easier for users to consume anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible replacement for #5622
This PR adds
pyo3_build_config::add_libpython_rpath_link_args(), to set rpath to libpython from crate build scripts.The idea here is that using
rpathshould make it trivial to link to the correct libpython; we already haveadd_python_framework_link_argswhich is doing the same thing (and should probably merge with this proposed function).I remove
pyo3-ffi-check's use of theextension-modulefeature and use this API instead, which should demonstrate if it works...