fixes #5202 -- treat the PYO3_BUILD_EXTENSION_MODULE env var the same as the extension-module feature

[alex]

No description provided.

[alex]

I couldn't see a great way to write a test case for this, so my plan is to send PRs to maturin and setuptools-rust to respect this env var, at which point once they're in a release it'll be easy to test.

[alex]

maturin: PyO3/maturin#2723

[alex]

setuptools-rust: PyO3/setuptools-rust#540

[alex]

@davidhewitt any chance we can sneak this in to 0.26?

[davidhewitt]

I think we can probably test the basics within this repo by checking the shared objects produced by the pytests module, maybe as part of pytests/noxfile.py? (And explicitly set the env var in that build, maybe)

I will do my best to give this a full review tonight, agreed it would be nice to put this in 0.26 so that maturin / setuptools-rust can add support.

[alex]

Hmm, so the problem is that until this is in a maturin release (the PR was merged there), setting the env var doesn't do anything :-) Once the maturin release is out I can definitely update the test.

Do we have any existing extension module tests that don't go through either maturin or rust-openssl?

[messense]

@alex Feel free to raise a PR in maturin to release a new patch version to unblock this. (or I can do it after work today.) Thanks!

[alex]

Almost bed time here, if you're able to get to it that'd be great, thank you!

[alex]

I'm very confused:

  ================ 181 passed, 1 skipped, 4094 warnings in 5.74s =================
  nox > Command pytest  failed with exit code -11

[alex]

Looks like only 3.14 is segfaulting, is this a known issue? I don't see how this PR could possibly cause this (which isn't to say it doesn't...)

[davidhewitt]

Try merging main, for reasons I haven't quite followed the CI plan is coming from the merge commit even though the fix for 3.14 is not on your branch.

[alex]

Easy enough! Thanks

[alex]

Phew, green now -- with test!

[davidhewitt]

Let's ship this 👍